Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c5235d3 authored by Naman Padhiar's avatar Naman Padhiar Committed by Gerrit - the friendly Code Review server
Browse files

cnss2: Avoid ASSERT in panic handler 



Avoid calling ASSERT from select_window API when it called
from panic handler. As device is already crashed, calling
ASSERT will just add unwanted prints and dump stacks.

Change-Id: If38be6d8e452c49cabfa059b4bf12b2f8a3c60a2
Signed-off-by: default avatarNaman Padhiar <npadhiar@codeaurora.org>
parent c7f857a0

drivers/net/wireless/cnss2/pci.c

+4 −1
Original line number Diff line number Diff line
@@ -685,6 +685,8 @@ int cnss_pci_check_link_status(struct cnss_pci_data *pci_priv) 


static void cnss_pci_select_window(struct cnss_pci_data *pci_priv, u32 offset)

{

	struct cnss_plat_data *plat_priv = pci_priv->plat_priv;



	u32 window = (offset >> WINDOW_SHIFT) & WINDOW_VALUE_MASK;

	u32 window_enable = WINDOW_ENABLE_BIT | window;

	u32 val;
@@ -703,7 +705,8 @@ static void cnss_pci_select_window(struct cnss_pci_data *pci_priv, u32 offset) 
	if (val != window_enable) {

		cnss_pr_err("Failed to config window register to 0x%x, current value: 0x%x\n",

			    window_enable, val);

		if (!cnss_pci_check_link_status(pci_priv))

		if (!cnss_pci_check_link_status(pci_priv) &&

		    !test_bit(CNSS_IN_PANIC, &plat_priv->driver_state))

			CNSS_ASSERT(0);

	}

}