Commit 7c4610ac authored Jul 05, 2023 by Pablo Neira Ayuso Committed by Greg Kroah-Hartman Jul 27, 2023

netfilter: nf_tables: unbind non-anonymous set if rule construction fails



[ 3e70489721b6c870252c9082c496703677240f53 ]

Otherwise a dangling reference to a rule object that is gone remains
in the set binding list.

Fixes: 26b5a5712eb8 ("netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 90d54ee3

net/netfilter/nf_tables_api.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -3987,6 +3987,8 @@ void nf_tables_deactivate_set(const struct nft_ctx ctx, struct nft_set set,
		nft_set_trans_unbind(ctx, set);
		if (nft_set_is_anonymous(set))
		nft_deactivate_next(ctx->net, set);
		else
		list_del_rcu(&binding->list);

		set->use--;
		break;