Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c25a826 authored by Artem Leonenko's avatar Artem Leonenko Committed by Greg Kroah-Hartman
Browse files

USB: gadget: ci13xxx: fix complete() callback for no_interrupt rq's 



CI13xxx UDC driver doesn't call complete() callback for requests
with flag no_interrupt set. Thus gadget drivers (like g_ether) are
never notifed about successfully (or not) transmitted requests. As
a result in case of g_ether and queued request with no_interrupt=1
fields g_ether is never notifed about sent packets and TX stalls.

Solution: treat no_interrupt flag like all other UDC drivers do and
call complete() callback for all requests.

Signed-off-by: default avatarArtem Leonenko <tikkeri@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent d9bb9c18

drivers/usb/gadget/ci13xxx_udc.c

+3 −3
Original line number Diff line number Diff line
@@ -1551,7 +1551,7 @@ __acquires(mEp->lock) 
		list_del_init(&mReq->queue);

		mReq->req.status = -ESHUTDOWN;



		if (!mReq->req.no_interrupt && mReq->req.complete != NULL) {

		if (mReq->req.complete != NULL) {

			spin_unlock(mEp->lock);

			mReq->req.complete(&mEp->ep, &mReq->req);

			spin_lock(mEp->lock);
@@ -1802,7 +1802,7 @@ __acquires(mEp->lock) 
		_hardware_enqueue(mEp, mReqEnq);

	}



	if (!mReq->req.no_interrupt && mReq->req.complete != NULL) {

	if (mReq->req.complete != NULL) {

		spin_unlock(mEp->lock);

		mReq->req.complete(&mEp->ep, &mReq->req);

		spin_lock(mEp->lock);
@@ -2213,7 +2213,7 @@ static int ep_dequeue(struct usb_ep *ep, struct usb_request *req) 
	list_del_init(&mReq->queue);

	req->status = -ECONNRESET;



	if (!mReq->req.no_interrupt && mReq->req.complete != NULL) {

	if (mReq->req.complete != NULL) {

		spin_unlock(mEp->lock);

		mReq->req.complete(&mEp->ep, &mReq->req);

		spin_lock(mEp->lock);