Commit 7c101939 authored Apr 14, 2023 by Xuan Zhuo Committed by Greg Kroah-Hartman Apr 26, 2023

virtio_net: bugfix overflow inside xdp_linearize_page()



[ Upstream commit 853618d5886bf94812f31228091cd37d308230f7 ]

Here we copy the data from the original buf to the new page. But we
not check that it may be overflow.

As long as the size received(including vnethdr) is greater than 3840
(PAGE_SIZE -VIRTIO_XDP_HEADROOM). Then the memcpy will overflow.

And this is completely possible, as long as the MTU is large, such
as 4096. In our test environment, this will cause crash. Since crash is
caused by the written memory, it is meaningless, so I do not include it.

Fixes: 72979a6c ("virtio_net: xdp, add slowpath case for non contiguous buffers")
Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 35dceaea

drivers/net/virtio_net.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -646,8 +646,13 @@ static struct page xdp_linearize_page(struct receive_queue rq,
		int page_off,
		unsigned int *len)
		{
		struct page *page = alloc_page(GFP_ATOMIC);
		int tailroom = SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
		struct page *page;

		if (page_off + *len + tailroom > PAGE_SIZE)
		return NULL;

		page = alloc_page(GFP_ATOMIC);
		if (!page)
		return NULL;

		@@ -655,7 +660,6 @@ static struct page xdp_linearize_page(struct receive_queue rq,
		page_off += *len;

		while (--*num_buf) {
		int tailroom = SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
		unsigned int buflen;
		void *buf;
		int off;