Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c0a33d6 authored by Vipul Pandya's avatar Vipul Pandya Committed by Roland Dreier
Browse files

RDMA/cxgb4: Don't wakeup threads for MPAv2 



Don't wakeup threads blocked in rdma_init/rdma_fini if we are on
MPAv2, and want to retry connection with MPAv1.

Stop ep-timer on getting MPA version mismatch, before doing the
abort_connection - in process_mpa_request.

Take care to stop ep-timer in error paths for process_mpa_request.

Signed-off-by: default avatarVipul Pandya <vipul@chelsio.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent fe7e0a4d

drivers/infiniband/hw/cxgb4/cm.c

+11 −1
Original line number Diff line number Diff line
@@ -1300,11 +1300,13 @@ static void process_mpa_request(struct c4iw_ep *ep, struct sk_buff *skb) 
	if (mpa->revision > mpa_rev) {

		printk(KERN_ERR MOD "%s MPA version mismatch. Local = %d,"

		       " Received = %d\n", __func__, mpa_rev, mpa->revision);

		stop_ep_timer(ep);

		abort_connection(ep, skb, GFP_KERNEL);

		return;

	}



	if (memcmp(mpa->key, MPA_KEY_REQ, sizeof(mpa->key))) {

		stop_ep_timer(ep);

		abort_connection(ep, skb, GFP_KERNEL);

		return;

	}
@@ -1315,6 +1317,7 @@ static void process_mpa_request(struct c4iw_ep *ep, struct sk_buff *skb) 
	 * Fail if there's too much private data.

	 */

	if (plen > MPA_MAX_PRIVATE_DATA) {

		stop_ep_timer(ep);

		abort_connection(ep, skb, GFP_KERNEL);

		return;

	}
@@ -1323,6 +1326,7 @@ static void process_mpa_request(struct c4iw_ep *ep, struct sk_buff *skb) 
	 * If plen does not account for pkt size

	 */

	if (ep->mpa_pkt_len > (sizeof(*mpa) + plen)) {

		stop_ep_timer(ep);

		abort_connection(ep, skb, GFP_KERNEL);

		return;

	}
@@ -3286,7 +3290,13 @@ static int peer_abort_intr(struct c4iw_dev *dev, struct sk_buff *skb) 


	/*

	 * Wake up any threads in rdma_init() or rdma_fini().

	 * However, if we are on MPAv2 and want to retry with MPAv1

	 * then, don't wake up yet.

	 */

	if (mpa_rev == 2 && !ep->tried_with_mpa_v1) {

		if (ep->com.state != MPA_REQ_SENT)

			c4iw_wake_up(&ep->com.wr_wait, -ECONNRESET);

	} else

		c4iw_wake_up(&ep->com.wr_wait, -ECONNRESET);

	sched(dev, skb);

	return 0;