Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ba19e77 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by kamasali Satyanarayan
Browse files

soc: qcom: llcc: Handle a second device without data corruption 



[ Upstream commit f1a1bc8775b26345aba2be278118999e7f661d3d ]

Usually there is only one llcc device. But if there were a second, even
a failed probe call would modify the global drv_data pointer. So check
if drv_data is valid before overwriting it.

Change-Id: Ie9bcc0686959b0c3bfb740963eed3ba399ed735e
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: a3134fb0 ("drivers: soc: Add LLCC driver")
Git-commit: cc1a1dcb
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
Link: https://lore.kernel.org/r/20230926083229.2073890-1-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarkamasali Satyanarayan <quic_kamasali@quicinc.com>
parent 9c9c087a

drivers/soc/qcom/llcc-slice.c

+3 −0
Original line number Diff line number Diff line
@@ -379,6 +379,9 @@ int qcom_llcc_probe(struct platform_device *pdev, 
	struct platform_device *llcc_edac, *llcc_perfmon;

	struct device_node *tcm_memory_node;



	if (!IS_ERR(drv_data))

		return -EBUSY;



	drv_data = devm_kzalloc(dev, sizeof(*drv_data), GFP_KERNEL);

	if (!drv_data) {

		ret = -ENOMEM;