Commit 7b9a88a3 authored Feb 17, 2017 by Florian Fainelli Committed by David S. Miller Feb 20, 2017

net: phy: Fix PHY unbind crash



The PHY library does not deal very well with bind and unbind events. The first
thing we would see is that we were not properly canceling the PHY state machine
workqueue, so we would be crashing while dereferencing phydev->drv since there
is no driver attached anymore.

Suggested-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cd2b7087

drivers/net/phy/phy_device.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1784,6 +1784,8 @@ static int phy_remove(struct device *dev)
		{
		struct phy_device *phydev = to_phy_device(dev);

		cancel_delayed_work_sync(&phydev->state_queue);

		mutex_lock(&phydev->lock);
		phydev->state = PHY_DOWN;
		mutex_unlock(&phydev->lock);