Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b2e7ade authored by Bruce Wang's avatar Bruce Wang Committed by Rob Clark
Browse files

drm/msm/dpu: Make dpu_plane_danger_signal_ctrl void 



Removed all impossible checks from the function, which eliminates
the need for a return value. This function is also never used
outside of dpu_plane.c, so the function is made static.

v3: Using helper function _dpu_plane_get_kms() instead of doing
it locally.

Signed-off-by: default avatarBruce Wang <bzwang@chromium.org>
Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarSean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent 1da03408

drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

+4 −22
Original line number Diff line number Diff line
@@ -365,35 +365,17 @@ static void _dpu_plane_set_qos_ctrl(struct drm_plane *plane, 
			&pdpu->pipe_qos_cfg);

}



int dpu_plane_danger_signal_ctrl(struct drm_plane *plane, bool enable)

static void dpu_plane_danger_signal_ctrl(struct drm_plane *plane, bool enable)

{

	struct dpu_plane *pdpu;

	struct msm_drm_private *priv;

	struct dpu_kms *dpu_kms;



	if (!plane || !plane->dev) {

		DPU_ERROR("invalid arguments\n");

		return -EINVAL;

	}



	priv = plane->dev->dev_private;

	if (!priv || !priv->kms) {

		DPU_ERROR("invalid KMS reference\n");

		return -EINVAL;

	}



	dpu_kms = to_dpu_kms(priv->kms);

	pdpu = to_dpu_plane(plane);

	struct dpu_plane *pdpu = to_dpu_plane(plane);

	struct dpu_kms *dpu_kms = _dpu_plane_get_kms(plane);



	if (!pdpu->is_rt_pipe)

		goto end;

		return;



	pm_runtime_get_sync(&dpu_kms->pdev->dev);

	_dpu_plane_set_qos_ctrl(plane, enable, DPU_PLANE_QOS_PANIC_CTRL);

	pm_runtime_put_sync(&dpu_kms->pdev->dev);



end:

	return 0;

}



/**