Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b115dd0 authored by Jesse Brandeburg's avatar Jesse Brandeburg Committed by Jeff Kirsher
Browse files

i40e: clean up debug_read_register 



There were some additional spaces and strange (double swapping) logic
in this function that I started looking at because sparse was warning.

This fixes the sparse warning and fixes up the other issues.

Change-ID: I72a91a4197cd45921602649040e6bd25e5f17c0a
Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 71e6163a

drivers/net/ethernet/intel/i40e/i40e_common.c

+4 −6
Original line number Diff line number Diff line
@@ -2137,17 +2137,15 @@ i40e_status i40e_aq_debug_read_register(struct i40e_hw *hw, 
	if (reg_val == NULL)

		return I40E_ERR_PARAM;



	i40e_fill_default_direct_cmd_desc(&desc,

					  i40e_aqc_opc_debug_read_reg);

	i40e_fill_default_direct_cmd_desc(&desc, i40e_aqc_opc_debug_read_reg);



	cmd_resp->address = cpu_to_le32(reg_addr);



	status = i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details);



	if (!status) {

		*reg_val = ((u64)cmd_resp->value_high << 32) |

			    (u64)cmd_resp->value_low;

		*reg_val = le64_to_cpu(*reg_val);

		*reg_val = ((u64)le32_to_cpu(cmd_resp->value_high) << 32) |

			   (u64)le32_to_cpu(cmd_resp->value_low);

	}



	return status;