Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7afc09c8 authored by Hangyu Hua's avatar Hangyu Hua Committed by Greg Kroah-Hartman
Browse files

yam: fix a memory leak in yam_siocdevprivate() 



[ Upstream commit 29eb31542787e1019208a2e1047bb7c76c069536 ]

ym needs to be free when ym->cmd != SIOCYAMSMCS.

Fixes: 0781168e ("yam: fix a missing-check bug")
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 51edc483

drivers/net/hamradio/yam.c

+1 −3
Original line number Diff line number Diff line
@@ -951,9 +951,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) 
				 sizeof(struct yamdrv_ioctl_mcs));

		if (IS_ERR(ym))

			return PTR_ERR(ym);

		if (ym->cmd != SIOCYAMSMCS)

			return -EINVAL;

		if (ym->bitrate > YAM_MAXBITRATE) {

		if (ym->cmd != SIOCYAMSMCS || ym->bitrate > YAM_MAXBITRATE) {

			kfree(ym);

			return -EINVAL;

		}