Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 7ae2227b authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Tudor Ambarus
Browse files

mtd: spi-nor: hisi-sfc: Add of_node_put() before break 



Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a break from the middle of the loop, there
is no put, thus causing a memory leak. Hence add an of_node_put before
the break.
Issue found with Coccinelle.

Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
parent 6597f0b0

drivers/mtd/spi-nor/hisi-sfc.c

+1 −0
Original line number Diff line number Diff line
@@ -401,6 +401,7 @@ static int hisi_spi_nor_register_all(struct hifmc_host *host) 


		if (host->num_chip == HIFMC_MAX_CHIP_NUM) {

			dev_warn(dev, "Flash device number exceeds the maximum chipselect number\n");

			of_node_put(np);

			break;

		}

	}