Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7aae7466 authored by Juergen Gross's avatar Juergen Gross Committed by Greg Kroah-Hartman
Browse files

x86/xen: disable Firmware First mode for correctable memory errors 



commit d759af38572f97321112a0852353613d18126038 upstream.

When running as Xen dom0 the kernel isn't responsible for selecting the
error handling mode, this should be handled by the hypervisor.

So disable setting FF mode when running as Xen pv guest. Not doing so
might result in boot splats like:

[    7.509696] HEST: Enabling Firmware First mode for corrected errors.
[    7.510382] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 2.
[    7.510383] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 3.
[    7.510384] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 4.
[    7.510384] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 5.
[    7.510385] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 6.
[    7.510386] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 7.
[    7.510386] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 8.

Reason is that the HEST ACPI table contains the real number of MCA
banks, while the hypervisor is emulating only 2 banks for guests.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
Reviewed-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/r/20200925140751.31381-1-jgross@suse.com


Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 47a4d540

arch/x86/xen/enlighten_pv.c

+9 −0
Original line number Diff line number Diff line
@@ -1382,6 +1382,15 @@ asmlinkage __visible void __init xen_start_kernel(void) 
		x86_init.mpparse.get_smp_config = x86_init_uint_noop;



		xen_boot_params_init_edd();



#ifdef CONFIG_ACPI

		/*

		 * Disable selecting "Firmware First mode" for correctable

		 * memory errors, as this is the duty of the hypervisor to

		 * decide.

		 */

		acpi_disable_cmcff = 1;

#endif

	}



	if (!boot_params.screen_info.orig_video_isVGA)