Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7aa42abc authored by Aradhya Bhatia's avatar Aradhya Bhatia Committed by Greg Kroah-Hartman
Browse files

drm/bridge: cdns-dsi: Fix connecting to next bridge 



commit 688eb4d465484bc2a3471a6a6f06f833b58c7867 upstream.

Fix the OF node pointer passed to the of_drm_find_bridge() call to find
the next bridge in the display chain.

The code to find the next panel (and create its panel-bridge) works
fine, but to find the next (non-panel) bridge does not.

To find the next bridge in the pipeline, we need to pass "np" - the OF
node pointer of the next entity in the devicetree chain. Passing
"of_node" to of_drm_find_bridge (which is what the code does currently)
will fetch the bridge for the cdns-dsi which is not what's required.

Fix that.

Fixes: e1923395 ("drm/bridge: Add Cadence DSI driver")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tested-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: default avatarAradhya Bhatia <a-bhatia1@ti.com>
Signed-off-by: default avatarAradhya Bhatia <aradhya.bhatia@linux.dev>
Link: https://lore.kernel.org/r/20250329113925.68204-2-aradhya.bhatia@linux.dev


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0ad37214

drivers/gpu/drm/bridge/cdns-dsi.c

+1 −1
Original line number Diff line number Diff line
@@ -959,7 +959,7 @@ static int cdns_dsi_attach(struct mipi_dsi_host *host, 
	if (!IS_ERR(panel)) {

		bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DSI);

	} else {

		bridge = of_drm_find_bridge(dev->dev.of_node);

		bridge = of_drm_find_bridge(np);

		if (!bridge)

			bridge = ERR_PTR(-EINVAL);

	}