Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 7a8b0e66 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: tps6524x: Remove *rdev[N_REGULATORS] from struct tps6524x 



Current code is using devm_regulator_register() so we don't need to store
*rdev for clean up, use a local variable instead.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 357db027

drivers/regulator/tps6524x-regulator.c

+4 −5
Original line number Diff line number Diff line
@@ -137,7 +137,6 @@ struct tps6524x { 
	struct spi_device	*spi;

	struct mutex		lock;

	struct regulator_desc	desc[N_REGULATORS];

	struct regulator_dev	*rdev[N_REGULATORS];

};



static int __read_reg(struct tps6524x *hw, int reg)
@@ -584,6 +583,7 @@ static int pmic_probe(struct spi_device *spi) 
	const struct supply_info *info = supply_info;

	struct regulator_init_data *init_data;

	struct regulator_config config = { };

	struct regulator_dev *rdev;

	int i;



	init_data = dev_get_platdata(dev);
@@ -616,10 +616,9 @@ static int pmic_probe(struct spi_device *spi) 
		config.init_data = init_data;

		config.driver_data = hw;



		hw->rdev[i] = devm_regulator_register(dev, &hw->desc[i],

						      &config);

		if (IS_ERR(hw->rdev[i]))

			return PTR_ERR(hw->rdev[i]);

		rdev = devm_regulator_register(dev, &hw->desc[i], &config);

		if (IS_ERR(rdev))

			return PTR_ERR(rdev);

	}



	return 0;