Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a79f71f authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

usbnet: fix memory allocation in helpers 



commit e65af5403e462ccd7dff6a045a886c64da598c2e upstream.

usbnet provides some helper functions that are also used in
the context of reset() operations. During a reset the other
drivers on a device are unable to operate. As that can be block
drivers, a driver for another interface cannot use paging
in its memory allocations without risking a deadlock.
Use GFP_NOIO in the helpers.

Fixes: 877bd862 ("usbnet: introduce usbnet 3 command helpers")
Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Link: https://lore.kernel.org/r/20220628093517.7469-1-oneukum@suse.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5af106f8

drivers/net/usb/usbnet.c

+2 −2
Original line number Diff line number Diff line
@@ -1987,7 +1987,7 @@ static int __usbnet_read_cmd(struct usbnet *dev, u8 cmd, u8 reqtype, 
		   cmd, reqtype, value, index, size);



	if (size) {

		buf = kmalloc(size, GFP_KERNEL);

		buf = kmalloc(size, GFP_NOIO);

		if (!buf)

			goto out;

	}
@@ -2019,7 +2019,7 @@ static int __usbnet_write_cmd(struct usbnet *dev, u8 cmd, u8 reqtype, 
		   cmd, reqtype, value, index, size);



	if (data) {

		buf = kmemdup(data, size, GFP_KERNEL);

		buf = kmemdup(data, size, GFP_NOIO);

		if (!buf)

			goto out;

	} else {