Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a2ae008 authored by Danila Chernetsov's avatar Danila Chernetsov Committed by Greg Kroah-Hartman
Browse files

scsi: megaraid: Fix mega_cmd_done() CMDID_INT_CMDS 



[ Upstream commit 75cb113cd43f06aaf4f1bda0069cfd5b98e909eb ]

When cmdid == CMDID_INT_CMDS, the 'cmds' pointer is NULL but is
dereferenced below.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 0f2bb84d ("[SCSI] megaraid: simplify internal command handling")
Signed-off-by: default avatarDanila Chernetsov <listdansp@mail.ru>
Link: https://lore.kernel.org/r/20230317175109.18585-1-listdansp@mail.ru


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a4245323

drivers/scsi/megaraid.c

+1 −0
Original line number Diff line number Diff line
@@ -1439,6 +1439,7 @@ mega_cmd_done(adapter_t *adapter, u8 completed[], int nstatus, int status) 
		 */

		if (cmdid == CMDID_INT_CMDS) {

			scb = &adapter->int_scb;

			cmd = scb->cmd;



			list_del_init(&scb->list);

			scb->state = SCB_FREE;