Commit 7a0cf42e authored Aug 10, 2017 by Markus Elfring Committed by Mark Brown Aug 10, 2017

ASoC: compress: Delete error messages for a failed memory allocation in snd_soc_new_compress()

Omit extra messages for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mark Brown <broonie@kernel.org>

sound/soc/soc-compress.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -764,15 +764,12 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num)
		direction = SND_COMPRESS_CAPTURE;

		compr = kzalloc(sizeof(*compr), GFP_KERNEL);
		if (compr == NULL) {
		snd_printk(KERN_ERR "Cannot allocate compr\n");
		if (!compr)
		return -ENOMEM;
		}

		compr->ops = devm_kzalloc(rtd->card->dev, sizeof(soc_compr_ops),
		GFP_KERNEL);
		if (compr->ops == NULL) {
		dev_err(rtd->card->dev, "Cannot allocate compressed ops\n");
		if (!compr->ops) {
		ret = -ENOMEM;
		goto compr_err;
		}