Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79f56690 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

ASoC: mediatek: mt8173-rt5650: Fix refcount leak in mt8173_rt5650_dev_probe 



[ Upstream commit efe2178d1a32492f99e7f1f2568eea5c88a85729 ]

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Fix refcount leak in some error paths.

Fixes: 0f83f929 ("ASoC: mediatek: Add machine driver for ALC5650 codec")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220603124243.31358-1-linmq006@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 4f97b5bb

sound/soc/mediatek/mt8173/mt8173-rt5650.c

+6 −3
Original line number Diff line number Diff line
@@ -266,7 +266,8 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev) 
	if (!mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[0].of_node) {

		dev_err(&pdev->dev,

			"Property 'audio-codec' missing or invalid\n");

		return -EINVAL;

		ret = -EINVAL;

		goto put_platform_node;

	}

	mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[1].of_node =

		mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[0].of_node;
@@ -279,7 +280,7 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev) 
			dev_err(&pdev->dev,

				"%s codec_capture_dai name fail %d\n",

				__func__, ret);

			return ret;

			goto put_platform_node;

		}

		mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[1].dai_name =

			codec_capture_dai;
@@ -301,7 +302,8 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev) 
	if (!mt8173_rt5650_dais[DAI_LINK_HDMI_I2S].codecs->of_node) {

		dev_err(&pdev->dev,

			"Property 'audio-codec' missing or invalid\n");

		return -EINVAL;

		ret = -EINVAL;

		goto put_platform_node;

	}

	card->dev = &pdev->dev;
@@ -310,6 +312,7 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev) 
		dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n",

			__func__, ret);



put_platform_node:

	of_node_put(platform_node);

	return ret;

}