Commit 79dcbd81 authored Dec 08, 2021 by José Expósito Committed by Greg Kroah-Hartman Dec 29, 2021

IB/qib: Fix memory leak in qib_user_sdma_queue_pkts()

[ Upstream commit bee90911e0138c76ee67458ac0d58b38a3190f65 ]

The wrong goto label was used for the error case and missed cleanup of the
pkt allocation.

Fixes: d39bf40e55e6 ("IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields")
Link: https://lore.kernel.org/r/20211208175238.29983-1-jose.exposito89@gmail.com


Addresses-Coverity-ID: 1493352 ("Resource leak")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 78874bca

drivers/infiniband/hw/qib/qib_user_sdma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct qib_devdata *dd,
		&addrlimit) \|\|
		addrlimit > type_max(typeof(pkt->addrlimit))) {
		ret = -EINVAL;
		goto free_pbc;
		goto free_pkt;
		}
		pkt->addrlimit = addrlimit;