Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7992e004 authored by Wenwen Wang's avatar Wenwen Wang Committed by Richard Weinberger
Browse files

ubifs: Fix memory leak in __ubifs_node_verify_hmac error path 



In __ubifs_node_verify_hmac(), 'hmac' is allocated through kmalloc().
However, it is not deallocated in the following execution if
ubifs_node_calc_hmac() fails, leading to a memory leak bug. To fix this
issue, free 'hmac' before returning the error.

Fixes: 49525e5e ("ubifs: Add helper functions for authentication support")
Signed-off-by: default avatarWenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent ce4d8b16

fs/ubifs/auth.c

+3 −1
Original line number Diff line number Diff line
@@ -479,8 +479,10 @@ int __ubifs_node_verify_hmac(const struct ubifs_info *c, const void *node, 
		return -ENOMEM;



	err = ubifs_node_calc_hmac(c, node, len, ofs_hmac, hmac);

	if (err)

	if (err) {

		kfree(hmac);

		return err;

	}



	err = crypto_memneq(hmac, node + ofs_hmac, hmac_len);