Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7992c188 authored by Mark Salyzyn's avatar Mark Salyzyn Committed by Marcel Holtmann
Browse files

Bluetooth: hidp: buffer overflow in hidp_process_report 



CVE-2018-9363

The buffer length is unsigned at all layers, but gets cast to int and
checked in hidp_process_report and can lead to a buffer overflow.
Switch len parameter to unsigned int to resolve issue.

This affects 3.18 and newer kernels.

Signed-off-by: default avatarMark Salyzyn <salyzyn@android.com>
Fixes: a4b1b587 ("HID: Bluetooth: hidp: make sure input buffers are big enough")
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Kees Cook <keescook@chromium.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-bluetooth@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: security@kernel.org
Cc: kernel-team@android.com
Acked-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent b3cadaa4

net/bluetooth/hidp/core.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -431,8 +431,8 @@ static void hidp_del_timer(struct hidp_session *session) 
		del_timer(&session->timer);

		del_timer(&session->timer);

}

}





static void hidp_process_report(struct hidp_session *session,

static void hidp_process_report(struct hidp_session *session, int type,

				int type, const u8 *data, int len, int intr)

				const u8 *data, unsigned int len, int intr)

{

{

	if (len > HID_MAX_BUFFER_SIZE)

	if (len > HID_MAX_BUFFER_SIZE)

		len = HID_MAX_BUFFER_SIZE;

		len = HID_MAX_BUFFER_SIZE;