Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79890c2e authored Feb 13, 2019 by Brian Masney Committed by Linus Walleij Feb 14, 2019

qcom: ssbi-gpio: correct boundary conditions in pm8xxx_domain_translate



SSBI GPIOs are numbered 1..ngpio, so the boundary check in
pm8xxx_domain_translate() is off by one. This patch corrects that check.

Signed-off-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent de744e01

drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -710,7 +710,8 @@ static int pm8xxx_domain_translate(struct irq_domain *domain,
		struct pm8xxx_gpio *pctrl = container_of(domain->host_data,
		struct pm8xxx_gpio, chip);

		if (fwspec->param_count != 2 \|\| fwspec->param[0] >= pctrl->chip.ngpio)
		if (fwspec->param_count != 2 \|\| fwspec->param[0] < 1 \|\|
		fwspec->param[0] > pctrl->chip.ngpio)
		return -EINVAL;

		*hwirq = fwspec->param[0] - PM8XXX_GPIO_PHYSICAL_OFFSET;