Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79348f6f authored by Sean Wang's avatar Sean Wang Committed by Linus Walleij
Browse files

pinctrl: mediatek: extend advanced pull support in pinctrl-mtk-common-v2.c 



Extend the advanced pull based on the legacy bias plus additional r0 and r1
to tweak the resistor level.

Signed-off-by: default avatarZhiyong Tao <zhiyong.tao@mediatek.com>
Signed-off-by: default avatarSean Wang <sean.wang@mediatek.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 750cd15d

drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c

+32 −5
Original line number Diff line number Diff line
@@ -476,6 +476,19 @@ int mtk_pinconf_adv_pull_set(struct mtk_pinctrl *hw, 


	err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_PUPD, arg);



	/* If PUPD register is not supported for that pin, let's fallback to

	 * general bias control.

	 */

	if (err == -ENOTSUPP) {

		if (hw->soc->bias_set) {

			err = hw->soc->bias_set(hw, desc, pullup);

			if (err)

				return err;

		} else {

			return -ENOTSUPP;

		}

	}



	return err;

}
@@ -487,12 +500,26 @@ int mtk_pinconf_adv_pull_get(struct mtk_pinctrl *hw, 
	int err;



	err = mtk_hw_get_value(hw, desc, PINCTRL_PIN_REG_PUPD, &t);



	/* If PUPD register is not supported for that pin, let's fallback to

	 * general bias control.

	 */

	if (err == -ENOTSUPP) {

		if (hw->soc->bias_get) {

			err = hw->soc->bias_get(hw, desc, pullup, val);

			if (err)

				return err;



		} else {

			return -ENOTSUPP;

		}

	} else {

		/* t == 0 supposes PULLUP for the customized PULL setup */

		if (err)

			return err;



		if (pullup ^ !t)

			return -EINVAL;

	}



	err = mtk_hw_get_value(hw, desc, PINCTRL_PIN_REG_R0, &t);

	if (err)