Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78d4b132 authored by Fuqian Huang's avatar Fuqian Huang Committed by Martin K. Petersen
Browse files

scsi: lpfc: use spin_lock_irqsave in IRQ context 



As spin_unlock_irq will enable interrupts.
Function lpfc_findnode_rpi is called from
    lpfc_sli_abts_err_handler (./drivers/scsi/lpfc/lpfc_sli.c)
 <- lpfc_sli_async_event_handler
 <- lpfc_sli_process_unsol_iocb
 <- lpfc_sli_handle_fast_ring_event
 <- lpfc_sli_fp_intr_handler
 <- lpfc_sli_intr_handler
 and lpfc_sli_intr_handler is an interrupt handler.

Interrupts are enabled in interrupt handler.  Use
spin_lock_irqsave/spin_unlock_irqrestore instead of spin_(un)lock_irq in
IRQ context to avoid this.

Signed-off-by: default avatarFuqian Huang <huangfq.daxian@gmail.com>
Reviewed-by: default avatarJames Smart <james.smart@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent ee9a256c

drivers/scsi/lpfc/lpfc_hbadisc.c

+3 −2
Original line number Diff line number Diff line
@@ -6065,10 +6065,11 @@ lpfc_findnode_rpi(struct lpfc_vport *vport, uint16_t rpi) 
{

	struct Scsi_Host *shost = lpfc_shost_from_vport(vport);

	struct lpfc_nodelist *ndlp;

	unsigned long flags;



	spin_lock_irq(shost->host_lock);

	spin_lock_irqsave(shost->host_lock, flags);

	ndlp = __lpfc_findnode_rpi(vport, rpi);

	spin_unlock_irq(shost->host_lock);

	spin_unlock_irqrestore(shost->host_lock, flags);

	return ndlp;

}