Commit 78706121 authored Sep 10, 2016 by Markus Elfring Committed by David S. Miller Sep 10, 2016

ATM-nicstar: Use kmalloc_array() in get_scq()



* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2594a2a9

drivers/atm/nicstar.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -871,8 +871,9 @@ static scq_info get_scq(ns_dev card, int size, u32 scd)
		kfree(scq);
		return NULL;
		}
		scq->skb = kmalloc(sizeof(struct sk_buff )
		(size / NS_SCQE_SIZE), GFP_KERNEL);
		scq->skb = kmalloc_array(size / NS_SCQE_SIZE,
		sizeof(*scq->skb),
		GFP_KERNEL);
		if (!scq->skb) {
		dma_free_coherent(&card->pcidev->dev,
		2 * size, scq->org, scq->dma);