Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77ae0d8e authored by Kai-Heng Feng's avatar Kai-Heng Feng Committed by Jiri Kosina
Browse files

HID: i2c-hid: Disable runtime PM on Goodix touchpad 



A Goodix touchpad doesn't work. Touching the touchpad can trigger IRQ
but there's no input event from HID subsystem.

Turns out it reports some invalid data:
[   22.136630] i2c_hid i2c-DELL091F:00: input: 0b 00 01 00 00 00 00 00 00 00 00

After some trial and error, it's another device that doesn't work well
with ON/SLEEP commands. Disable runtime PM to fix the issue.

Signed-off-by: default avatarKai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent ee46967f

drivers/hid/hid-ids.h

+3 −0
Original line number Diff line number Diff line
@@ -461,6 +461,9 @@ 
#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_010A 0x010a

#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100



#define I2C_VENDOR_ID_GOODIX		0x27c6

#define I2C_DEVICE_ID_GOODIX_01F0	0x01f0



#define USB_VENDOR_ID_GOODTOUCH		0x1aad

#define USB_DEVICE_ID_GOODTOUCH_000f	0x000f

drivers/hid/i2c-hid/i2c-hid-core.c

+2 −0
Original line number Diff line number Diff line
@@ -179,6 +179,8 @@ static const struct i2c_hid_quirks { 
		I2C_HID_QUIRK_DELAY_AFTER_SLEEP },

	{ USB_VENDOR_ID_LG, I2C_DEVICE_ID_LG_8001,

		I2C_HID_QUIRK_NO_RUNTIME_PM },

	{ I2C_VENDOR_ID_GOODIX, I2C_DEVICE_ID_GOODIX_01F0,

		I2C_HID_QUIRK_NO_RUNTIME_PM },

	{ 0, 0 }

};