Commit 76e28f5f authored Jan 10, 2018 by Wei Yongjun Committed by Linus Walleij Jan 11, 2018

gpio: thunderx: fix error return code in thunderx_gpio_probe()



Fix to return error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 5a2a3002 ("gpio: Add gpio driver support for ThunderX and OCTEON-TX")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 92a8046c

drivers/gpio/gpio-thunderx.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -553,8 +553,10 @@ static int thunderx_gpio_probe(struct pci_dev *pdev,
		txgpio->irqd = irq_domain_create_hierarchy(irq_get_irq_data(txgpio->msix_entries[0].vector)->domain,
		0, 0, of_node_to_fwnode(dev->of_node),
		&thunderx_gpio_irqd_ops, txgpio);
		if (!txgpio->irqd)
		if (!txgpio->irqd) {
		err = -ENOMEM;
		goto out;
		}

		/* Push on irq_data and the domain for each line. */
		for (i = 0; i < ngpio; i++) {