Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7645d26f authored by Zhaoxiong Yuan's avatar Zhaoxiong Yuan Committed by Vinod Koul
Browse files

dmaengine: idma64: replace spin_lock_irqsave with spin_lock 



idma64_chan_irq() is invoked in hardirq handle function, it is unnecessary
to call spin_lock_irqsave.

Signed-off-by: default avatarZhaoxiong Yuan <yuanzhx326@gmail.com>
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 5b394b2d

drivers/dma/idma64.c

+2 −3
Original line number Diff line number Diff line
@@ -142,9 +142,8 @@ static void idma64_chan_irq(struct idma64 *idma64, unsigned short c, 
{

	struct idma64_chan *idma64c = &idma64->chan[c];

	struct idma64_desc *desc;

	unsigned long flags;



	spin_lock_irqsave(&idma64c->vchan.lock, flags);

	spin_lock(&idma64c->vchan.lock);

	desc = idma64c->desc;

	if (desc) {

		if (status_err & (1 << c)) {
@@ -161,7 +160,7 @@ static void idma64_chan_irq(struct idma64 *idma64, unsigned short c, 
		if (idma64c->desc == NULL || desc->status == DMA_ERROR)

			idma64_stop_transfer(idma64c);

	}

	spin_unlock_irqrestore(&idma64c->vchan.lock, flags);

	spin_unlock(&idma64c->vchan.lock);

}



static irqreturn_t idma64_irq(int irq, void *dev)