Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 762982db authored by Roger Quadros's avatar Roger Quadros Committed by Felipe Balbi
Browse files

usb: phy: phy-generic: Fix reset behaviour on legacy boot 



The gpio-desc migration done in v4.0 caused a regression
with legacy boots due to reversed reset logic.
e.g. omap3-beagle USB host breaks on legacy boot.

Request the reset GPIO with GPIOF_ACTIVE_LOW flag so that
it matches the driver logic and pin behaviour.

Fixes: e9f2cefb ("usb: phy: generic: migrate to gpio_desc")
Cc: <stable@vger.kernel.org> # 4.0+
Tested-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarRoger Quadros <rogerq@ti.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 523d5daf

drivers/usb/phy/phy-generic.c

+2 −1
Original line number Diff line number Diff line
@@ -232,7 +232,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop, 
		clk_rate = pdata->clk_rate;

		needs_vcc = pdata->needs_vcc;

		if (gpio_is_valid(pdata->gpio_reset)) {

			err = devm_gpio_request_one(dev, pdata->gpio_reset, 0,

			err = devm_gpio_request_one(dev, pdata->gpio_reset,

						    GPIOF_ACTIVE_LOW,

						    dev_name(dev));

			if (!err)

				nop->gpiod_reset =