Commit 760b61d7 authored Aug 18, 2017 by Ard Biesheuvel Committed by Ingo Molnar Aug 21, 2017

efi/libstub/arm64: Use hidden attribute for struct screen_info reference



To prevent the compiler from emitting absolute references to screen_info
when building position independent code, redeclare the symbol with hidden
visibility.

Tested-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20170818194947.19347-3-ard.biesheuvel@linaro.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent f56ab9a5

arch/arm64/include/asm/efi.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -81,6 +81,9 @@ static inline unsigned long efi_get_max_initrd_addr(unsigned long dram_base,
		#define alloc_screen_info(x...) &screen_info
		#define free_screen_info(x...)

		/* redeclare as 'hidden' so the compiler will generate relative references */
		extern struct screen_info screen_info __attribute__((__visibility__("hidden")));

		static inline void efifb_setup_from_dmi(struct screen_info si, const char opt)
		{
		}