Commit 76022db3 authored Feb 04, 2011 by Masami Hiramatsu Committed by Arnaldo Carvalho de Melo Feb 07, 2011

tracing/kprobes: Cleanup strict_strtol() using code



Since strict_strtol() accepts minus digits started with '-', it doesn't
need to invert after converting.

Cc: 2nddept-manager@sdl.hitachi.co.jp
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <20110204125153.9507.49335.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent f50c2169

kernel/trace/trace_kprobe.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -767,16 +767,15 @@ static int __parse_probe_arg(char arg, const struct fetch_type t,
		}
		break;
		case '+': /* deref memory */
		arg++; /* Skip '+', because strict_strtol() rejects it. */
		case '-':
		tmp = strchr(arg, '(');
		if (!tmp)
		break;
		*tmp = '\0';
		ret = strict_strtol(arg + 1, 0, &offset);
		ret = strict_strtol(arg, 0, &offset);
		if (ret)
		break;
		if (arg[0] == '-')
		offset = -offset;
		arg = tmp + 1;
		tmp = strrchr(arg, ')');
		if (tmp) {