Commit 75eac7b5 authored Mar 22, 2019 by Wen Yang Committed by David S. Miller Mar 23, 2019

net: ethernet: ti: fix possible object reference leak



The call to of_get_child_by_name returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./drivers/net/ethernet/ti/netcp_ethss.c:3661:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3654, but without a corresponding object release within this function.
./drivers/net/ethernet/ti/netcp_ethss.c:3665:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3654, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Wingman Kwok <w-kwok2@ti.com>
Cc: Murali Karicheri <m-karicheri2@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>

parent be693df3

drivers/net/ethernet/ti/netcp_ethss.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -3657,12 +3657,16 @@ static int gbe_probe(struct netcp_device netcp_device, struct device dev,

		ret = netcp_txpipe_init(&gbe_dev->tx_pipe, netcp_device,
		gbe_dev->dma_chan_name, gbe_dev->tx_queue_id);
		if (ret)
		if (ret) {
		of_node_put(interfaces);
		return ret;
		}

		ret = netcp_txpipe_open(&gbe_dev->tx_pipe);
		if (ret)
		if (ret) {
		of_node_put(interfaces);
		return ret;
		}

		/* Create network interfaces */
		INIT_LIST_HEAD(&gbe_dev->gbe_intf_head);