Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75a8c1ff authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf annotate: Add PERCENT_HITS_GLOBAL percent value 



Adding and computing global hits percent value for annotation line.
Storing it in struct annotation_data percent array under new
PERCENT_HITS_GLOBAL index.

At the moment it's not displayed, it's coming in following patches.

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20180804130521.11408-10-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 6d9f0c2d

tools/perf/util/annotate.c

+7 −1
Original line number Diff line number Diff line
@@ -1759,6 +1759,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args) 
}



static void calc_percent(struct sym_hist *sym_hist,

			 struct hists *hists,

			 struct annotation_data *data,

			 s64 offset, s64 end)

{
@@ -1776,6 +1777,10 @@ static void calc_percent(struct sym_hist *sym_hist, 
		data->he.nr_samples = hits;

		data->percent[PERCENT_HITS_LOCAL] = 100.0 * hits / sym_hist->nr_samples;

	}



	if (hists->stats.nr_non_filtered_samples)

		data->percent[PERCENT_HITS_GLOBAL] = 100.0 * hits / hists->stats.nr_non_filtered_samples;



}



static void annotation__calc_percent(struct annotation *notes,
@@ -1795,6 +1800,7 @@ static void annotation__calc_percent(struct annotation *notes, 
		end  = next ? next->offset : len;



		for_each_group_evsel(evsel, leader) {

			struct hists *hists = evsel__hists(evsel);

			struct annotation_data *data;

			struct sym_hist *sym_hist;
@@ -1803,7 +1809,7 @@ static void annotation__calc_percent(struct annotation *notes, 
			sym_hist = annotation__histogram(notes, evsel->idx);

			data = &al->data[i++];



			calc_percent(sym_hist, data, al->offset, end);

			calc_percent(sym_hist, hists, data, al->offset, end);

		}

	}

}

tools/perf/util/annotate.h

+1 −0
Original line number Diff line number Diff line
@@ -103,6 +103,7 @@ struct sym_hist_entry { 


enum {

	PERCENT_HITS_LOCAL,

	PERCENT_HITS_GLOBAL,

	PERCENT_MAX,

};