Commit 7579d84b authored Oct 08, 2018 by Nathan Chancellor Committed by David S. Miller Oct 10, 2018

isdn/hisax: amd7930_fn: Remove unnecessary parentheses



Clang warns when multiple sets of parentheses are used for a single
conditional statement.

drivers/isdn/hisax/amd7930_fn.c:628:32: warning: equality comparison
with extraneous parentheses [-Wparentheses-equality]
                if ((cs->dc.amd7930.ph_state == 8)) {
                     ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
drivers/isdn/hisax/amd7930_fn.c:628:32: note: remove extraneous
parentheses around the comparison to silence this warning
                if ((cs->dc.amd7930.ph_state == 8)) {
                    ~                        ^   ~
drivers/isdn/hisax/amd7930_fn.c:628:32: note: use '=' to turn this
equality comparison into an assignment
                if ((cs->dc.amd7930.ph_state == 8)) {
                                             ^~
                                             =
1 warning generated.

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ffd177de

drivers/isdn/hisax/amd7930_fn.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -625,7 +625,7 @@ Amd7930_l1hw(struct PStack st, int pr, void arg)
		break;
		case (HW_RESET \| REQUEST):
		spin_lock_irqsave(&cs->lock, flags);
		if ((cs->dc.amd7930.ph_state == 8)) {
		if (cs->dc.amd7930.ph_state == 8) {
		/* b-channels off, PH-AR cleared
		* change to F3 */
		Amd7930_ph_command(cs, 0x20, "HW_RESET REQUEST"); //LMR1 bit 5