Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 750de03d authored by Steve French's avatar Steve French Committed by Greg Kroah-Hartman
Browse files

smbdirect: missing rc checks while waiting for rdma events 



commit 0555b221528e9cb11f5766dcdee19c809187e42e upstream.

There were two places where we weren't checking for error
(e.g. ERESTARTSYS) while waiting for rdma resolution.

Addresses-Coverity: 1462165 ("Unchecked return value")
Reviewed-by: default avatarTom Talpey <tom@talpey.com>
Reviewed-by: default avatarLong Li <longli@microsoft.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Signed-off-by: default avatarAnastasia Belova <abelova@astralinux.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5776aeee

fs/cifs/smbdirect.c

+12 −2
Original line number Diff line number Diff line
@@ -607,8 +607,13 @@ static struct rdma_cm_id *smbd_create_id( 
		log_rdma_event(ERR, "rdma_resolve_addr() failed %i\n", rc);

		goto out;

	}

	wait_for_completion_interruptible_timeout(

	rc = wait_for_completion_interruptible_timeout(

		&info->ri_done, msecs_to_jiffies(RDMA_RESOLVE_TIMEOUT));

	/* e.g. if interrupted returns -ERESTARTSYS */

	if (rc < 0) {

		log_rdma_event(ERR, "rdma_resolve_addr timeout rc: %i\n", rc);

		goto out;

	}

	rc = info->ri_rc;

	if (rc) {

		log_rdma_event(ERR, "rdma_resolve_addr() completed %i\n", rc);
@@ -621,8 +626,13 @@ static struct rdma_cm_id *smbd_create_id( 
		log_rdma_event(ERR, "rdma_resolve_route() failed %i\n", rc);

		goto out;

	}

	wait_for_completion_interruptible_timeout(

	rc = wait_for_completion_interruptible_timeout(

		&info->ri_done, msecs_to_jiffies(RDMA_RESOLVE_TIMEOUT));

	/* e.g. if interrupted returns -ERESTARTSYS */

	if (rc < 0)  {

		log_rdma_event(ERR, "rdma_resolve_addr timeout rc: %i\n", rc);

		goto out;

	}

	rc = info->ri_rc;

	if (rc) {

		log_rdma_event(ERR, "rdma_resolve_route() completed %i\n", rc);