Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75035fe2 authored by Ben Segal's avatar Ben Segal Committed by Oded Gabbay
Browse files

habanalabs: fix F/W download in BE architecture 



writeX macros might perform byte-swapping in BE architectures. As our F/W
is in LE format, we need to make sure no byte-swapping will occur.

There is a standard kernel function (called memcpy_toio) for copying data
to I/O area which is used in a lot of drivers to download F/W to PCIe
adapters. That function also makes sure the data is copied "as-is",
without byte-swapping.

This patch use that function to copy the F/W to the GOYA ASIC instead of
writeX macros.

Signed-off-by: default avatarBen Segal <bpsegal20@gmail.com>
Reviewed-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
parent 609488bc

drivers/misc/habanalabs/firmware_if.c

+2 −17
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ int hl_fw_push_fw_to_device(struct hl_device *hdev, const char *fw_name, 
{

	const struct firmware *fw;

	const u64 *fw_data;

	size_t fw_size, i;

	size_t fw_size;

	int rc;



	rc = request_firmware(&fw, fw_name, hdev->dev);
@@ -45,22 +45,7 @@ int hl_fw_push_fw_to_device(struct hl_device *hdev, const char *fw_name, 


	fw_data = (const u64 *) fw->data;



	if ((fw->size % 8) != 0)

		fw_size -= 8;



	for (i = 0 ; i < fw_size ; i += 8, fw_data++, dst += 8) {

		if (!(i & (0x80000 - 1))) {

			dev_dbg(hdev->dev,

				"copied so far %zu out of %zu for %s firmware",

				i, fw_size, fw_name);

			usleep_range(20, 100);

		}



		writeq(*fw_data, dst);

	}



	if ((fw->size % 8) != 0)

		writel(*(const u32 *) fw_data, dst);

	memcpy_toio(dst, fw_data, fw_size);



out:

	release_firmware(fw);