Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74d7c5af authored by Magnus Damm's avatar Magnus Damm Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (9235): Precalculate vivi yuv values 



This patch improves the color space conversion code in vivi.c to
directly draw with precalculated YUV values as palette instead of
drawing with YUV that is calculated from RGB for every two pixels.
This way we eliminate the need for 9 multiplications every two pixels.

A side effect of this patch is that the time counter is changed from
green text on black background to white text on black background.

Signed-off-by: default avatarMagnus Damm <damm@igel.co.jp>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent d54c17e4

drivers/media/video/vivi.c

+58 −59
Original line number Original line Diff line number Diff line
@@ -190,6 +190,7 @@ struct vivi_fh { 
	struct videobuf_queue      vb_vidq;

	struct videobuf_queue      vb_vidq;





	enum v4l2_buf_type         type;

	enum v4l2_buf_type         type;

	unsigned char              bars[8][3];

};

};





/* ------------------------------------------------------------------

/* ------------------------------------------------------------------
@@ -234,43 +235,53 @@ static u8 bars[8][3] = { 
#define TSTAMP_MAX_Y TSTAMP_MIN_Y+15

#define TSTAMP_MAX_Y TSTAMP_MIN_Y+15

#define TSTAMP_MIN_X 64

#define TSTAMP_MIN_X 64





static void gen_line(char *basep, int inipos, int wmax,

static void gen_twopix(struct vivi_fh *fh, unsigned char *buf, int colorpos)

		int hmax, int line, int count, char *timestr)

{

{

	int  w, i, j, y;

	unsigned char r_y, g_u, b_v;

	int pos = inipos;

	unsigned char *p;

	char *p, *s;

	int color;

	u8   chr, r, g, b, color;





	/* We will just duplicate the second pixel at the packet */

	r_y = fh->bars[colorpos][0]; /* R or precalculated Y */

	wmax /= 2;

	g_u = fh->bars[colorpos][1]; /* G or precalculated U */



	b_v = fh->bars[colorpos][2]; /* B or precalculated V */

	/* Generate a standard color bar pattern */

	for (w = 0; w < wmax; w++) {

		int colorpos = ((w + count) * 8/(wmax + 1)) % 8;

		r = bars[colorpos][0];

		g = bars[colorpos][1];

		b = bars[colorpos][2];





	for (color = 0; color < 4; color++) {

	for (color = 0; color < 4; color++) {

			p = basep + pos;

		p = buf + color;





		switch (color) {

		switch (color) {

		case 0:

		case 0:

		case 2:

		case 2:

				*p = TO_Y(r, g, b);	/* Luma */

			*p = r_y;

			break;

			break;

		case 1:

		case 1:

				*p = TO_U(r, g, b);	/* Cb */

			*p = g_u;

			break;

			break;

		case 3:

		case 3:

				*p = TO_V(r, g, b);	/* Cr */

			*p = b_v;

			break;

			break;

		}

		}

			pos++;

	}

	}

}

}





static void gen_line(struct vivi_fh *fh, char *basep, int inipos, int wmax,

		int hmax, int line, int count, char *timestr)

{

	int  w, i, j;

	int pos = inipos;

	char *s;

	u8 chr;



	/* We will just duplicate the second pixel at the packet */

	wmax /= 2;



	/* Generate a standard color bar pattern */

	for (w = 0; w < wmax; w++) {

		int colorpos = ((w + count) * 8/(wmax + 1)) % 8;



		gen_twopix(fh, basep + pos, colorpos);

		pos += 4; /* only 16 bpp supported for now */

	}



	/* Checks if it is possible to show timestamp */

	/* Checks if it is possible to show timestamp */

	if (TSTAMP_MAX_Y >= hmax)

	if (TSTAMP_MAX_Y >= hmax)

		goto end;

		goto end;
@@ -283,38 +294,12 @@ static void gen_line(char *basep, int inipos, int wmax, 
		for (s = timestr; *s; s++) {

		for (s = timestr; *s; s++) {

			chr = rom8x16_bits[(*s-0x30)*16+line-TSTAMP_MIN_Y];

			chr = rom8x16_bits[(*s-0x30)*16+line-TSTAMP_MIN_Y];

			for (i = 0; i < 7; i++) {

			for (i = 0; i < 7; i++) {

				if (chr & 1 << (7 - i)) {

					/* Font color*/

					r = 0;

					g = 198;

					b = 0;

				} else {

					/* Background color */

					r = bars[BLACK][0];

					g = bars[BLACK][1];

					b = bars[BLACK][2];

				}



				pos = inipos + j * 2;

				pos = inipos + j * 2;

				for (color = 0; color < 4; color++) {

				/* Draw white font on black background */

					p = basep + pos;

				if (chr & 1 << (7 - i))



					gen_twopix(fh, basep + pos, WHITE);

					y = TO_Y(r, g, b);

				else



					gen_twopix(fh, basep + pos, BLACK);

					switch (color) {

					case 0:

					case 2:

						*p = TO_Y(r, g, b); /* Luma */

						break;

					case 1:

						*p = TO_U(r, g, b); /* Cb */

						break;

					case 3:

						*p = TO_V(r, g, b); /* Cr */

						break;

					}

					pos++;

				}

				j++;

				j++;

			}

			}

		}

		}
@@ -324,8 +309,9 @@ static void gen_line(char *basep, int inipos, int wmax, 
	return;

	return;

}

}





static void vivi_fillbuff(struct vivi_dev *dev, struct vivi_buffer *buf)

static void vivi_fillbuff(struct vivi_fh *fh, struct vivi_buffer *buf)

{

{

	struct vivi_dev *dev = fh->dev;

	int h , pos = 0;

	int h , pos = 0;

	int hmax  = buf->vb.height;

	int hmax  = buf->vb.height;

	int wmax  = buf->vb.width;

	int wmax  = buf->vb.width;
@@ -341,7 +327,7 @@ static void vivi_fillbuff(struct vivi_dev *dev, struct vivi_buffer *buf) 
		return;

		return;





	for (h = 0; h < hmax; h++) {

	for (h = 0; h < hmax; h++) {

		gen_line(tmpbuf, 0, wmax, hmax, h, dev->mv_count,

		gen_line(fh, tmpbuf, 0, wmax, hmax, h, dev->mv_count,

			 dev->timestr);

			 dev->timestr);

		memcpy(vbuf + pos, tmpbuf, wmax * 2);

		memcpy(vbuf + pos, tmpbuf, wmax * 2);

		pos += wmax*2;

		pos += wmax*2;
@@ -410,7 +396,7 @@ static void vivi_thread_tick(struct vivi_fh *fh) 
	do_gettimeofday(&buf->vb.ts);

	do_gettimeofday(&buf->vb.ts);





	/* Fill buffer */

	/* Fill buffer */

	vivi_fillbuff(dev, buf);

	vivi_fillbuff(fh, buf);

	dprintk(dev, 1, "filled buffer %p\n", buf);

	dprintk(dev, 1, "filled buffer %p\n", buf);





	wake_up(&buf->vb.done);

	wake_up(&buf->vb.done);
@@ -714,6 +700,8 @@ static int vidioc_s_fmt_vid_cap(struct file *file, void *priv, 
{

{

	struct vivi_fh  *fh = priv;

	struct vivi_fh  *fh = priv;

	struct videobuf_queue *q = &fh->vb_vidq;

	struct videobuf_queue *q = &fh->vb_vidq;

	unsigned char r, g, b;

	int k;





	int ret = vidioc_try_fmt_vid_cap(file, fh, f);

	int ret = vidioc_try_fmt_vid_cap(file, fh, f);

	if (ret < 0)

	if (ret < 0)
@@ -733,6 +721,17 @@ static int vidioc_s_fmt_vid_cap(struct file *file, void *priv, 
	fh->vb_vidq.field = f->fmt.pix.field;

	fh->vb_vidq.field = f->fmt.pix.field;

	fh->type          = f->type;

	fh->type          = f->type;





	/* precalculate color bar values to speed up rendering */

	for (k = 0; k < 8; k++) {

		r = bars[k][0];

		g = bars[k][1];

		b = bars[k][2];



		fh->bars[k][0] = TO_Y(r, g, b);	/* Luma */

		fh->bars[k][1] = TO_U(r, g, b);	/* Cb */

		fh->bars[k][2] = TO_V(r, g, b);	/* Cr */

	}



	ret = 0;

	ret = 0;

out:

out:

	mutex_unlock(&q->vb_lock);

	mutex_unlock(&q->vb_lock);