Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74bc2abc authored by Heiko Stuebner's avatar Heiko Stuebner Committed by Joerg Roedel
Browse files

iommu/rockchip: Free irqs in shutdown handler 



In the iommu's shutdown handler we disable runtime-pm which could
result in the irq-handler running unclocked and since commit
    3fc7c5c0 ("iommu/rockchip: Handle errors returned from PM framework")
we warn about that fact.

This can cause warnings on shutdown on some Rockchip machines, so
free the irqs in the shutdown handler before we disable runtime-pm.

Reported-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Fixes: 3fc7c5c0 ("iommu/rockchip: Handle errors returned from PM framework")
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Tested-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 6bf4ca7f

drivers/iommu/rockchip-iommu.c

+6 −0
Original line number Diff line number Diff line
@@ -1241,6 +1241,12 @@ static int rk_iommu_probe(struct platform_device *pdev) 


static void rk_iommu_shutdown(struct platform_device *pdev)

{

	struct rk_iommu *iommu = platform_get_drvdata(pdev);

	int i = 0, irq;



	while ((irq = platform_get_irq(pdev, i++)) != -ENXIO)

		devm_free_irq(iommu->dev, irq, iommu);



	pm_runtime_force_suspend(&pdev->dev);

}