Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74aea4b7 authored by Arkadiusz Kubalewski's avatar Arkadiusz Kubalewski Committed by Greg Kroah-Hartman
Browse files

i40e: Fix firmware LLDP agent related warning 



[ Upstream commit 71d6fdba4b2d82fdd883fec31dee77fbcf59773a ]

Make warning meaningful for the user.

Previously the trace:
"Starting FW LLDP agent failed: error: I40E_ERR_ADMIN_QUEUE_ERROR, I40E_AQ_RC_EAGAIN"
was produced when user tried to start Firmware LLDP agent,
just after it was stopped with sequence:
ethtool --set-priv-flags <dev> disable-fw-lldp on
ethtool --set-priv-flags <dev> disable-fw-lldp off
(without any delay between the commands)
At that point the firmware is still processing stop command, the behavior
is expected.

Fixes: c1041d07 ("i40e: Missing response checks in driver when starting/stopping FW LLDP")
Signed-off-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: default avatarArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Tested-by: default avatarImam Hassan Reza Biswas <imam.hassan.reza.biswas@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b2ab34e8

drivers/net/ethernet/intel/i40e/i40e_ethtool.c

+4 −0
Original line number Diff line number Diff line
@@ -5087,6 +5087,10 @@ static int i40e_set_priv_flags(struct net_device *dev, u32 flags) 
					dev_warn(&pf->pdev->dev,

						 "Device configuration forbids SW from starting the LLDP agent.\n");

					return -EINVAL;

				case I40E_AQ_RC_EAGAIN:

					dev_warn(&pf->pdev->dev,

						 "Stop FW LLDP agent command is still being processed, please try again in a second.\n");

					return -EBUSY;

				default:

					dev_warn(&pf->pdev->dev,

						 "Starting FW LLDP agent failed: error: %s, %s\n",