Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 749a2b66 authored by Steffen Trumtrar's avatar Steffen Trumtrar Committed by David S. Miller
Browse files

net/macb: clear tx/rx completion flags in ISR 



At least in the cadence IP core on the Xilinx Zynq SoC the TCOMP/RCOMP flags
are not auto-cleaned. As these flags are evaluated, they need to be cleaned.

Signed-off-by: default avatarSteffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 19e016d6

drivers/net/ethernet/cadence/macb.c

+3 −0
Original line number Diff line number Diff line
@@ -485,6 +485,8 @@ static void macb_tx_interrupt(struct macb *bp) 
	status = macb_readl(bp, TSR);

	macb_writel(bp, TSR, status);



	macb_writel(bp, ISR, MACB_BIT(TCOMP));



	netdev_vdbg(bp->dev, "macb_tx_interrupt status = 0x%03lx\n",

		(unsigned long)status);
@@ -736,6 +738,7 @@ static irqreturn_t macb_interrupt(int irq, void *dev_id) 
			 * now.

			 */

			macb_writel(bp, IDR, MACB_RX_INT_FLAGS);

			macb_writel(bp, ISR, MACB_BIT(RCOMP));



			if (napi_schedule_prep(&bp->napi)) {

				netdev_vdbg(bp->dev, "scheduling RX softirq\n");