Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 746364f2 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

net: devlink: add warning for ndo_get_phys_port_name set when not needed 



Currently if the driver registers devlink port instance, it should set
the devlink port attributes as well. Then the devlink core is able to
obtain physical port name itself, no need for driver to implement
the ndo. Once all drivers will implement devlink port registration,
this ndo should be removed. This warning guides new
drivers to do things as they should be done.

Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Reviewed-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f1fa719c

net/core/devlink.c

+18 −0
Original line number Diff line number Diff line
@@ -5358,6 +5358,24 @@ static void __devlink_port_type_set(struct devlink_port *devlink_port, 
void devlink_port_type_eth_set(struct devlink_port *devlink_port,

			       struct net_device *netdev)

{

	/* If driver registers devlink port, it should set devlink port

	 * attributes accordingly so the compat functions are called

	 * and the original ops are not used.

	 */

	if (netdev->netdev_ops->ndo_get_phys_port_name) {

		/* Some drivers use the same set of ndos for netdevs

		 * that have devlink_port registered and also for

		 * those who don't. Make sure that ndo_get_phys_port_name

		 * returns -EOPNOTSUPP here in case it is defined.

		 * Warn if not.

		 */

		const struct net_device_ops *ops = netdev->netdev_ops;

		char name[IFNAMSIZ];

		int err;



		err = ops->ndo_get_phys_port_name(netdev, name, sizeof(name));

		WARN_ON(err != -EOPNOTSUPP);

	}

	__devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_ETH, netdev);

}

EXPORT_SYMBOL_GPL(devlink_port_type_eth_set);