Commit 743f7b51 authored Feb 02, 2023 by Parav Pandit Committed by Greg Kroah-Hartman Feb 22, 2023

virtio-net: Keep stop() to follow mirror sequence of open()



[ Upstream commit 63b114042d8a9c02d9939889177c36dbdb17a588 ]

Cited commit in fixes tag frees rxq xdp info while RQ NAPI is
still enabled and packet processing may be ongoing.

Follow the mirror sequence of open() in the stop() callback.
This ensures that when rxq info is unregistered, no rx
packet processing is ongoing.

Fixes: 754b8a21 ("virtio_net: setup xdp_rxq_info")
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Link: https://lore.kernel.org/r/20230202163516.12559-1-parav@nvidia.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent aed972fb

drivers/net/virtio_net.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1910,8 +1910,8 @@ static int virtnet_close(struct net_device *dev)
		cancel_delayed_work_sync(&vi->refill);

		for (i = 0; i < vi->max_queue_pairs; i++) {
		xdp_rxq_info_unreg(&vi->rq[i].xdp_rxq);
		napi_disable(&vi->rq[i].napi);
		xdp_rxq_info_unreg(&vi->rq[i].xdp_rxq);
		virtnet_napi_tx_disable(&vi->sq[i].napi);
		}