Commit 73dd601b authored Sep 25, 2021 by Pablo Neira Ayuso Committed by Greg Kroah-Hartman Nov 17, 2021

netfilter: nft_dynset: relax superfluous check on set updates



[ Upstream commit 7b1394892de8d95748d05e3ee41e85edb4abbfa1 ]

Relax this condition to make add and update commands idempotent for sets
with no timeout. The eval function already checks if the set element
timeout is available and updates it if the update command is used.

Fixes: 22fe54d5 ("netfilter: nf_tables: add support for dynamic set updates")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 62f6260f

net/netfilter/nft_dynset.c

+1 −10

Original line number	Diff line number	Diff line
		@@ -164,17 +164,8 @@ static int nft_dynset_init(const struct nft_ctx *ctx,
		return -EBUSY;

		priv->op = ntohl(nla_get_be32(tb[NFTA_DYNSET_OP]));
		switch (priv->op) {
		case NFT_DYNSET_OP_ADD:
		case NFT_DYNSET_OP_DELETE:
		break;
		case NFT_DYNSET_OP_UPDATE:
		if (!(set->flags & NFT_SET_TIMEOUT))
		return -EOPNOTSUPP;
		break;
		default:
		if (priv->op > NFT_DYNSET_OP_DELETE)
		return -EOPNOTSUPP;
		}

		timeout = 0;
		if (tb[NFTA_DYNSET_TIMEOUT] != NULL) {