Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7360abf3 authored by Alexander Aring's avatar Alexander Aring Committed by Greg Kroah-Hartman
Browse files

net: ieee802154: handle iftypes as u32 



[ Upstream commit 451dc48c806a7ce9fbec5e7a24ccf4b2c936e834 ]

This patch fixes an issue that an u32 netlink value is handled as a
signed enum value which doesn't fit into the range of u32 netlink type.
If it's handled as -1 value some BIT() evaluation ends in a
shift-out-of-bounds issue. To solve the issue we set the to u32 max which
is s32 "-1" value to keep backwards compatibility and let the followed enum
values start counting at 0. This brings the compiler to never handle the
enum as signed and a check if the value is above NL802154_IFTYPE_MAX should
filter -1 out.

Fixes: f3ea5e44 ("ieee802154: add new interface command")
Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20211112030916.685793-1-aahringo@redhat.com


Signed-off-by: default avatarStefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 4421a196

include/net/nl802154.h

+4 −3
Original line number Diff line number Diff line
@@ -19,6 +19,8 @@ 
 *

 */



#include <linux/types.h>



#define NL802154_GENL_NAME "nl802154"



enum nl802154_commands {
@@ -150,10 +152,9 @@ enum nl802154_attrs { 
};



enum nl802154_iftype {

	/* for backwards compatibility TODO */

	NL802154_IFTYPE_UNSPEC = -1,

	NL802154_IFTYPE_UNSPEC = (~(__u32)0),



	NL802154_IFTYPE_NODE,

	NL802154_IFTYPE_NODE = 0,

	NL802154_IFTYPE_MONITOR,

	NL802154_IFTYPE_COORD,