Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 734be97b authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Takashi Iwai
Browse files

ALSA: opti9xx: mark expected switch fall-throughs 



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 402016 ("Missing break in switch")
Addresses-Coverity-ID: 1056542 ("Missing break in switch")
Addresses-Coverity-ID: 1339579 ("Missing break in switch")
Addresses-Coverity-ID: 1369526 ("Missing break in switch")
Addresses-Coverity-ID: 1369529 ("Missing break in switch")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 3e313f34

sound/isa/opti9xx/miro.c

+5 −0
Original line number Original line Diff line number Diff line
@@ -176,10 +176,13 @@ static int aci_busy_wait(struct snd_miro_aci *aci) 
			switch (timeout-ACI_MINTIME) {

			switch (timeout-ACI_MINTIME) {

			case 0 ... 9:

			case 0 ... 9:

				out /= 10;

				out /= 10;

				/* fall through */

			case 10 ... 19:

			case 10 ... 19:

				out /= 10;

				out /= 10;

				/* fall through */

			case 20 ... 30:

			case 20 ... 30:

				out /= 10;

				out /= 10;

				/* fall through */

			default:

			default:

				set_current_state(TASK_UNINTERRUPTIBLE);

				set_current_state(TASK_UNINTERRUPTIBLE);

				schedule_timeout(out);

				schedule_timeout(out);
@@ -834,6 +837,7 @@ static unsigned char snd_miro_read(struct snd_miro *chip, 
			retval = inb(chip->mc_base + 9);

			retval = inb(chip->mc_base + 9);

			break;

			break;

		}

		}

		/* fall through */





	case OPTi9XX_HW_82C929:

	case OPTi9XX_HW_82C929:

		retval = inb(chip->mc_base + reg);

		retval = inb(chip->mc_base + reg);
@@ -863,6 +867,7 @@ static void snd_miro_write(struct snd_miro *chip, unsigned char reg, 
			outb(value, chip->mc_base + 9);

			outb(value, chip->mc_base + 9);

			break;

			break;

		}

		}

		/* fall through */





	case OPTi9XX_HW_82C929:

	case OPTi9XX_HW_82C929:

		outb(value, chip->mc_base + reg);

		outb(value, chip->mc_base + reg);