Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73415b4e authored by Sam Ravnborg's avatar Sam Ravnborg
Browse files

drm/fb: remove unused function: drm_gem_fbdev_fb_create() 



After migrating several drivers to the generic fbdev
emulation there are no users left of drm_gem_fbdev_fb_create.
Delete the function.

Noticed that there was no callers while browsing
around in the drm_fb* code.

The code that referenced the function was removed by:
commit 13aff184 ("drm/qxl: remove dead qxl fbdev emulation code")

The actual use was removed by:
commit 26d4707d ("drm/qxl: use generic fbdev emulation")

v2:
- Updated changelog based on feedback from Noralf

Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Reviewed-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190721140610.GA20842@ravnborg.org
parent b72cb0dc

drivers/gpu/drm/drm_gem_framebuffer_helper.c

+0 −43
Original line number Diff line number Diff line
@@ -322,46 +322,3 @@ int drm_gem_fb_simple_display_pipe_prepare_fb(struct drm_simple_display_pipe *pi 
	return drm_gem_fb_prepare_fb(&pipe->plane, plane_state);

}

EXPORT_SYMBOL(drm_gem_fb_simple_display_pipe_prepare_fb);
 


/**

 * drm_gem_fbdev_fb_create - Create a GEM backed &drm_framebuffer for fbdev

 *                           emulation

 * @dev: DRM device

 * @sizes: fbdev size description

 * @pitch_align: Optional pitch alignment

 * @obj: GEM object backing the framebuffer

 * @funcs: Optional vtable to be used for the new framebuffer object when the

 *         dirty callback is needed.

 *

 * This function creates a framebuffer from a &drm_fb_helper_surface_size

 * description for use in the &drm_fb_helper_funcs.fb_probe callback.

 *

 * Returns:

 * Pointer to a &drm_framebuffer on success or an error pointer on failure.

 */

struct drm_framebuffer *

drm_gem_fbdev_fb_create(struct drm_device *dev,

			struct drm_fb_helper_surface_size *sizes,

			unsigned int pitch_align, struct drm_gem_object *obj,

			const struct drm_framebuffer_funcs *funcs)

{

	struct drm_mode_fb_cmd2 mode_cmd = { 0 };



	mode_cmd.width = sizes->surface_width;

	mode_cmd.height = sizes->surface_height;

	mode_cmd.pitches[0] = sizes->surface_width *

			      DIV_ROUND_UP(sizes->surface_bpp, 8);

	if (pitch_align)

		mode_cmd.pitches[0] = roundup(mode_cmd.pitches[0],

					      pitch_align);

	mode_cmd.pixel_format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp,

							    sizes->surface_depth);

	if (obj->size < mode_cmd.pitches[0] * mode_cmd.height)

		return ERR_PTR(-EINVAL);



	if (!funcs)

		funcs = &drm_gem_fb_funcs;



	return drm_gem_fb_alloc(dev, &mode_cmd, &obj, 1, funcs);

}

EXPORT_SYMBOL(drm_gem_fbdev_fb_create);

include/drm/drm_gem_framebuffer_helper.h

+0 −7
Original line number Diff line number Diff line
@@ -33,11 +33,4 @@ int drm_gem_fb_prepare_fb(struct drm_plane *plane, 
			  struct drm_plane_state *state);

int drm_gem_fb_simple_display_pipe_prepare_fb(struct drm_simple_display_pipe *pipe,

					      struct drm_plane_state *plane_state);



struct drm_framebuffer *

drm_gem_fbdev_fb_create(struct drm_device *dev,

			struct drm_fb_helper_surface_size *sizes,

			unsigned int pitch_align, struct drm_gem_object *obj,

			const struct drm_framebuffer_funcs *funcs);



#endif