Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7320308b authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

tty: serial: owl: Fix missing clk_disable_unprepare() in owl_uart_probe 



[ Upstream commit bcea0f547ec1a2ee44d429aaf0334633e386e67c ]

Fix the missing clk_disable_unprepare() before return
from owl_uart_probe() in the error handling case.

Fixes: abf42d2f333b ("tty: serial: owl: add "much needed" clk_prepare_enable()")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220307105135.11698-1-linmq006@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 9ae3d073

drivers/tty/serial/owl-uart.c

+1 −0
Original line number Diff line number Diff line
@@ -695,6 +695,7 @@ static int owl_uart_probe(struct platform_device *pdev) 
	owl_port->port.uartclk = clk_get_rate(owl_port->clk);

	if (owl_port->port.uartclk == 0) {

		dev_err(&pdev->dev, "clock rate is zero\n");

		clk_disable_unprepare(owl_port->clk);

		return -EINVAL;

	}

	owl_port->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP | UPF_LOW_LATENCY;