Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72fcd2be authored by Huazhong Tan's avatar Huazhong Tan Committed by David S. Miller
Browse files

net: hns3: fixes wrong place enabling ROCE HW error when loading 



The ROCE HW errors should only be enabled when initializing ROCE's
client, the current code enable it no matter initializing NIC or
ROCE client.

So this patch fixes it.

Fixes: 00ea6e5f ("net: hns3: delay and separate enabling of NIC and ROCE HW errors")
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7cf9c069

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+8 −6
Original line number Diff line number Diff line
@@ -8349,6 +8349,14 @@ static int hclge_init_roce_client_instance(struct hnae3_ae_dev *ae_dev, 
		goto init_roce_err;

	}



	/* Enable roce ras interrupts */

	ret = hclge_config_rocee_ras_interrupt(hdev, true);

	if (ret) {

		dev_err(&ae_dev->pdev->dev,

			"fail(%d) to enable roce ras interrupts\n", ret);

		goto init_roce_err;

	}



	hnae3_set_client_init_flag(client, ae_dev, 1);



	return 0;
@@ -8403,12 +8411,6 @@ static int hclge_init_client_instance(struct hnae3_client *client, 
		}

	}



	/* Enable roce ras interrupts */

	ret = hclge_config_rocee_ras_interrupt(hdev, true);

	if (ret)

		dev_err(&ae_dev->pdev->dev,

			"fail(%d) to enable roce ras interrupts\n", ret);



	return ret;



clear_nic: