Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 724e1443 authored by Steffen Maier's avatar Steffen Maier Committed by Martin K. Petersen
Browse files

scsi: zfcp: update kernel message for invalid FCP_CMND length, it's not the CDB 



The CDB is just a part inside of FCP_CMND, see zfcp_fc_scsi_to_fcp().
While at it, fix the device driver reaction: adapter not LUN shutdown.

Signed-off-by: default avatarSteffen Maier <maier@linux.ibm.com>
Reviewed-by: default avatarBenjamin Block <bblock@linux.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9704154f

drivers/s390/scsi/zfcp_fsf.c

+2 −5
Original line number Original line Diff line number Diff line
@@ -2090,11 +2090,8 @@ static void zfcp_fsf_fcp_handler_common(struct zfcp_fsf_req *req, 
		break;

		break;

	case FSF_CMND_LENGTH_NOT_VALID:

	case FSF_CMND_LENGTH_NOT_VALID:

		dev_err(&req->adapter->ccw_device->dev,

		dev_err(&req->adapter->ccw_device->dev,

			"Incorrect CDB length %d, LUN 0x%016Lx on "

			"Incorrect FCP_CMND length %d, FCP device closed\n",

			"port 0x%016Lx closed\n",

			req->qtcb->bottom.io.fcp_cmnd_length);

			req->qtcb->bottom.io.fcp_cmnd_length,

			(unsigned long long)zfcp_scsi_dev_lun(sdev),

			(unsigned long long)zfcp_sdev->port->wwpn);

		zfcp_erp_adapter_shutdown(req->adapter, 0, "fssfch4");

		zfcp_erp_adapter_shutdown(req->adapter, 0, "fssfch4");

		req->status |= ZFCP_STATUS_FSFREQ_ERROR;

		req->status |= ZFCP_STATUS_FSFREQ_ERROR;

		break;

		break;