Commit 71e0ab5b authored Sep 30, 2022 by Jianglei Nie Committed by Greg Kroah-Hartman Oct 26, 2022

bnx2x: fix potential memory leak in bnx2x_tpa_stop()



[ Upstream commit b43f9acbb8942b05252be83ac25a81cec70cc192 ]

bnx2x_tpa_stop() allocates a memory chunk from new_data with
bnx2x_frag_alloc(). The new_data should be freed when gets some error.
But when "pad + len > fp->rx_buf_size" is true, bnx2x_tpa_stop() returns
without releasing the new_data, which will lead to a memory leak.

We should free the new_data with bnx2x_frag_free() when "pad + len >
fp->rx_buf_size" is true.

Fixes: 07b0f009 ("bnx2x: fix possible panic under memory stress")
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 360aa721

drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -787,6 +787,7 @@ static void bnx2x_tpa_stop(struct bnx2x bp, struct bnx2x_fastpath fp,
	BNX2X_ERR("skb_put is about to fail... pad %d len %d rx_buf_size %d\n",		BNX2X_ERR("skb_put is about to fail... pad %d len %d rx_buf_size %d\n",
	pad, len, fp->rx_buf_size);		pad, len, fp->rx_buf_size);
	bnx2x_panic();		bnx2x_panic();
			bnx2x_frag_free(fp, new_data);
	return;		return;
	}		}
	#endif		#endif